Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instructions, simplified pre-commit CI action #4

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

tomassebestik
Copy link
Member

@tomassebestik tomassebestik commented Jul 12, 2024

  • ci(pre-commit-action): updated to simplified version provided by GitHub
  • docs(readme): updated instructions for action integration, limit more the workflow privileges
  • ci: add CODEOWNERS file

@tomassebestik tomassebestik self-assigned this Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tomassebestik, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6b82e6c

@tomassebestik tomassebestik requested review from kumekay and hfudev July 12, 2024 07:45
@tomassebestik
Copy link
Member Author

@kumekay @hfudev Did some minor changes, mostly instructions for repo maintainers regarding integration. PTAL! Many thanks.

@tomassebestik tomassebestik added the Status: Reviewing Issue is being reviewed label Jul 12, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
@tomassebestik tomassebestik force-pushed the docs/update-action-intergation-instructions branch from 5f8d841 to 6b82e6c Compare July 17, 2024 08:44
@tomassebestik tomassebestik merged commit fb17367 into v1 Jul 17, 2024
4 checks passed
@tomassebestik tomassebestik deleted the docs/update-action-intergation-instructions branch July 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewing Issue is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants