Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(device): Update info about Github, Gitlab runner setup #99

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

Description

This MR updates CI target runner setup README with recent findings from applying the Docker workaround for accessing USB devices on GitLab runners.

It was found out, that the plugdev group is not avaliable on GitLab runners, thus the docker container is run without it. Also removing it from there.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky self-assigned this Dec 4, 2024
@erhankur
Copy link

erhankur commented Dec 4, 2024

@peter-marcisovsky thanks. LGTM

Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peter-marcisovsky peter-marcisovsky force-pushed the refactor/update_ci_runner_setup_readme branch from 175ba92 to b3e58cb Compare December 5, 2024 08:56
@peter-marcisovsky peter-marcisovsky merged commit 7ffd815 into master Dec 5, 2024
29 checks passed
@peter-marcisovsky peter-marcisovsky deleted the refactor/update_ci_runner_setup_readme branch December 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants