Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tinyusb): Run tinyusb tests in CI for esp32p4 #95

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

peter-marcisovsky
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky commented Dec 3, 2024

Description

This MR enables esp_tinyusb tests in CI on a new usb_device esp32p4 runner.

The new runner BrnoRPIG009 was updated with a script introduced in #75, allowing us to access USB devices from running docker container.

In esp_tinyusb, there are 3 groups of tests:

  • pytest_cdc.py - Test is run in CI
  • pytest_usb_device.py - Test not run in CI, missing teradown function in tinyusb (also bvalid signal test not tested on esp32p4)
  • pytest_vendor.py - Test not run in CI due to Docker container problems accessing a vendor specific device

Related

  • IDF-11684 Run esp_tinyusb tests on esp32p4 in GH CI
  • IDF-11345 Run esp_tinyusb tests in GH CI

Follow-up

  • IDF-11804 Invesitagate usage of VBUS monitor on HS PHY for esp32p4

Testing

To pass current CI tests


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky added the Status: In Progress Issue is being worked on label Dec 3, 2024
@peter-marcisovsky peter-marcisovsky self-assigned this Dec 3, 2024
@peter-marcisovsky peter-marcisovsky force-pushed the ci/run_p4_tinyusb_tests branch 3 times, most recently from e471bdf to ba230e6 Compare December 3, 2024 21:09
@peter-marcisovsky peter-marcisovsky marked this pull request as ready for review December 4, 2024 08:42
@peter-marcisovsky peter-marcisovsky added Status: Reviewing Issue is being reviewed and removed Status: In Progress Issue is being worked on labels Dec 4, 2024
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise LGTM.

    - New CI target runner usb_device esp32p4
@peter-marcisovsky peter-marcisovsky merged commit c105afa into master Dec 4, 2024
29 checks passed
@peter-marcisovsky peter-marcisovsky added Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Dec 9, 2024
@peter-marcisovsky peter-marcisovsky deleted the ci/run_p4_tinyusb_tests branch December 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants