-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(esp_tinyusb): Added tusb_teardown() call while tinyusb_driver_uninstall() #39
base: master
Are you sure you want to change the base?
Conversation
@tore-espressif , @peter-marcisovsky I posted two questions for both of you, because it seems that we can make it better and we can use it. I need that for enumeration driver testing (but maybe I will eliminate esp_tinyusb component from the chain, but anyway), so feel free to check it out when possible. Meanwhile, I will go and cover the Enum Driver as much as I can. |
d7cb17d
to
c14eebb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some observations from using the test app
Is there a timeline for this feature to be finalized? |
Hi @finger563 , This feature allows the re-configure the driver with these changes: espressif/tinyusb#27 Meanwhile, this feature should be available in the upstream of TinyUSB, if anything it is possible to use it. Sorry for the inconvenience. |
87ddae1
to
85c3227
Compare
ef29b89
to
7bcc554
Compare
da569b5
to
2954367
Compare
@tore-espressif @peter-marcisovsky To enable the CI (I am expecting the teardown_device test to fail), it is required to release Feel free to review the changes in current PR and I will relaunch CI after the tinyusb release (Which I planned on 22th of December, but will do that next Monday, 16th). UPD: we are running only cdc test, not all of them, so there is not problem with CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some comments.
I am having some issues with running the test locally. Will try to fix it an maybe add something else to the review.
device/esp_tinyusb/test_apps/teardown_device/main/test_teardown.c
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/pytest_teardown_device.py
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/main/test_teardown.c
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/pytest_teardown_device.py
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/main/test_teardown.c
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/pytest_teardown_device.py
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/pytest_teardown_device.py
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/pytest_teardown_device.py
Outdated
Show resolved
Hide resolved
device/esp_tinyusb/test_apps/teardown_device/main/test_teardown.c
Outdated
Show resolved
Hide resolved
5a9d94d
to
4be9e95
Compare
f6dc83c
to
fae1686
Compare
dfd0deb
to
a1e0772
Compare
a1e0772
to
d302232
Compare
0ca5094
to
2f2c9de
Compare
Requirements
tud_deinit()
feature was implemented in upstream, starting with version v0.17.0.Description
tusb_teardown()
call whiletinyusb_driver_uninstall()
Testing
Note: when amount of teardown configured to 0, then only one install-uninstall routine is fulfilled.
Related issues
espressif/tinyusb
PR: feature(usbd): Added tud_teardown() tinyusb#27 (closed, because of synchronizing with upstream v0.17)