-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(labels): add organization default issue Labels configurations #22
base: main
Are you sure you want to change the base?
Conversation
@tomassebestik I'd like to clarify a few points:
|
color: '#0E8A16' | ||
|
||
- name: 'Status: Cancelled' | ||
description: 'Canceled in progress' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Canceled in progress' sounds ambiguous.
'Issue was cancelled' sounds better.
|
||
- name: 'Status: Awaiting Response' | ||
description: 'Awaiting a response from the author' | ||
color: '#FF1493' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not status. Should be:
name: 'Awaiting Response'
color: '#C5DEF5'
There is also rule automation mirroring this label from Jira to GH and vice versa. Also for this reason, this cannot be 'Status: Awaiting Response'
- name: 'Invalid' | ||
description: "This doesn't seem right" | ||
color: '#e5e47a' | ||
aliases: ['invalid'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label is sort of duplicated by Cannot Reproduce, Won't Do and Duplicate resolutions.
|
||
- name: 'Status: Pending' | ||
description: 'Blocked by some other factor' | ||
color: '#fef2c0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though some projects use this status in Jira, I couldn't find a single one GH issue or PR with this status. Can be removed.
- name: 'Type: Dependencies' | ||
description: 'Dependencies and version updates' | ||
color: '#FE8547' | ||
aliases: ['dependencies'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels starting with 'Type: ' indicate that this label represents Jira issue type. Dependencies is not an issue type in Jira.
|
||
- name: 'Type: Performance' | ||
description: 'Issue related to project performance' | ||
color: '#fbca04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels starting with 'Type: ' indicate that this label represents Jira issue type. Performance is not an issue type in Jira.
- name: 'Type: Infrastructure' | ||
description: 'Issue related to project performance' | ||
color: '#c5a251' | ||
aliases: ['infrastructure'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels starting with 'Type: ' indicate that this label represents Jira issue type. Infrastructure is not an issue type in Jira.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And description is the same as for 'Type: Performance'
- name: 'Type: Enhancement' | ||
description: 'Issue related to project performance' | ||
color: '#adecee' | ||
aliases: ['enhancement'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels starting with 'Type: ' indicate that this label represents Jira issue type. Enhancement is not an issue type in Jira. Also this type is synonymous to Improvement type that exists and is used in Jira.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And description is the same as for 'Type: Performance'
- name: 'Type: Security' | ||
description: 'Security updates' | ||
color: '##D9AEC5' | ||
aliases: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labels starting with 'Type: ' indicate that this label represents Jira issue type. Security is not an issue type in Jira.
Description
Setting Labels in Organization Settings (GitHub Organization Settings -> Repository Labels) work only as defaults:
(Reference: Managing Default Labels for Repositories)
This PR is for now only list of standard Espressif issue/PR labels as a reference - will be used for automated labels sync.
Config files can be combined and projects grouped. For example, all org projects will have set 'global-labels', then defined subset of projects 'global-labels' + 'component-labels', etc ...
Next steps (TODO)
We plan to integrate it with label sync GH action and sync labels to org projects from one place, but this needs to be tested first.
Related