Allow one timing to cancel others #6744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
See feature request #985
Adds a method
cancel´ to
MultiClickTrigger` so that one trigger can conditionally cancel others when it fires.Types of changes
Related issue or feature (if applicable): (partially) fixes esphome/feature-requests#985
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).I did not find any tests for the multi-click trigger. As I'm new to the codebase, I am not sure how I would go about testing this.
If user exposed functionality or configuration variables are added/changed:
Please give me an indication if this PR is likely to be merged, then I will write some docs.