-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add lint-staged
#565
Conversation
Hi @coderaiser!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by running Read more about contributing to ESLint here |
7e44330
to
d278972
Compare
Co-authored-by: Nitin Kumar <[email protected]>
Hi @coderaiser!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
Thanks so much for taking a look at this! As mentioned, we already have a setup for this in the |
package.json
Outdated
@@ -77,6 +82,7 @@ | |||
"generate-alpharelease": "eslint-generate-prerelease alpha", | |||
"generate-betarelease": "eslint-generate-prerelease beta", | |||
"generate-rcrelease": "eslint-generate-prerelease rc", | |||
"publish-release": "eslint-publish-release" | |||
"publish-release": "eslint-publish-release", | |||
"prepare": "node node_modules/yorkie/bin/install.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a prepare
script doesn't seem necessary because yorkie
already runs its bin/install.js
on install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, just removed it
Co-authored-by: Nitin Kumar <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for others to review.
According to #562 (comment).
husky
to runprecommit
hook;lint-staged
to lint*.js
files;rollup
before lint, since it can produce an error:npm run fixlint
,npm run build
used expanded commands to speed things up;eslint
with a--fix
flag, sinceESLint
fixes most issues;