feat: add suggestions to no-unused-vars
#18352
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
lib/rules/no-unused-vars.js
Outdated
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| "use strict"; | |||
|
|
|||
| // const { parents } = require("cheerio/lib/api/traversing"); | |||
| // const { remove } = require("../linter/rule-fixer"); | |||
There was a problem hiding this comment.
Looks like your editor might have added some unintentional imports?
|
@eslint/eslint-team, code in this PR seems to work fine but having linting error that |
|
It's required to return a value in fixers (to catch possible errors). if you don't want to fix in some cases, please use |
Thanks for reply! but is this suggestion also true for the following code? return fixer.removeRange(parent.parent.range);because it actually returns a value and having error |
|
I think it's ready for review now. |
| * @returns {Object} fixer object | ||
| */ | ||
| function fixVariables(node) { | ||
| if (node.parent.type === "VariableDeclarator") { |
There was a problem hiding this comment.
It looks like you're using node.parent a lot, which requires looking up that property each time. I'd suggest saving a reference to both the parent and parent type so you don't have to keep evaluating it each time:
const parent = node.parent;
const parentType = parent.type;There was a problem hiding this comment.
Here node.parent is just used in fixVariable function and parent is already declared as
const parent = id.parentis it ok if i don't replace node.parent for now because it will help me if i use the function later?
lib/rules/no-unused-vars.js
Outdated
| return fixer.removeRange(node.range); | ||
| } | ||
|
|
||
| if (sourceCode.getTokenBefore(node).value === "(" && sourceCode.getTokenAfter(node).value === ",") { |
There was a problem hiding this comment.
You're also doing getTokenBefore(node) and getTokenAfter(node) a few times here. It's best to store those values in a variable to save the function call.
lib/rules/no-unused-vars.js
Outdated
| return node.elements.filter(e => e !== null).length === 1; | ||
| } | ||
|
|
||
| if (parent.type === "VariableDeclarator") { |
There was a problem hiding this comment.
Same comment about references throughout. We want to avoid a.b.c.d as much as possible.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
added suggestion to
no-unused-varsrule.Is there anything you'd like reviewers to focus on?
Fixes: #17545