Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jsdoc/no-multi-asterisks with allowWhitespace: true #17900

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

kecrily
Copy link
Member

@kecrily kecrily commented Dec 22, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Change eslint-config-eslint

What changes did you make? (Give an overview)

Avoid breaking the list being in the JSDoc comment below.

/**
 * The method does 2 things:
 * * Thing 1
 * * Thing 2
 */
const x = () => {}

ref eslint/eslint-github-bot#201 (comment)

Is there anything you'd like reviewers to focus on?

@kecrily kecrily requested a review from a team as a code owner December 22, 2023 16:20
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Dec 22, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 8590fd9
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6585b743b418e40008406fe4

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 3826cdf into main Dec 22, 2023
17 checks passed
@nzakas nzakas deleted the chore/eslint-jsdoc branch December 22, 2023 21:26
bmish added a commit to bmish/eslint that referenced this pull request Dec 27, 2023
* main:
  chore: use jsdoc/no-multi-asterisks with allowWhitespace: true (eslint#17900)
  chore: fix getting scope in tests (eslint#17899)
  fix!: Parsing 'exported' comment using parseListConfig (eslint#17675)
  docs: updated examples of `max-lines` rule (eslint#17898)
  feat!: Remove valid-jsdoc and require-jsdoc (eslint#17694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants