New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct upcoming release date after patch releases #557

Merged

nzakas merged 1 commit into main from fix-next-version-date

Apr 23, 2024

Member

mdjermanovic commented Apr 23, 2024

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Logic that calculates the upcoming release date didn't account for Monday's patch releases, so we currently have a wrong date on the site:

It should be 3 May, not 10 May.

What changes did you make? (Give an overview)

Updated the logic to calculate the upcoming release date by using the fact that we have a release every second Friday starting from a certain date.

Related Issues

Is there anything you'd like reviewers to focus on?


fix: correct next release date after patch releases

c031c0c

eslint-github-bot bot added the bug label

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for new-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/6627ccfe6a67a10008f3fb51
😎 Deploy Preview	https://deploy-preview-557--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/6627ccfef831bb00081a2c51
😎 Deploy Preview	https://deploy-preview-557--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/6627ccfe274e4c000860d468
😎 Deploy Preview	https://deploy-preview-557--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/6627ccfe63155e000852dd46
😎 Deploy Preview	https://deploy-preview-557--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/6627ccfe23e1ad0008643e33
😎 Deploy Preview	https://deploy-preview-557--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/6627ccfe7675480008a8829e
😎 Deploy Preview	https://deploy-preview-557--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/6627ccfef504390008de0dba
😎 Deploy Preview	https://deploy-preview-557--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 23, 2024 •

edited

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`c031c0c`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/6627ccfe63155e000852dd4b
😎 Deploy Preview	https://deploy-preview-557--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdjermanovic added the accepted label

Member

fasttime commented Apr 23, 2024

Thanks! I can confirm that running npm run fetch:stats after setting the ESLINT_GITHUB_TOKEN env variable did recreate src/_data/stats.json with "nextVersionDate": "2024-05-03".

fasttime approved these changes

View reviewed changes

Member

fasttime left a comment

LGTM.

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM.

Member

nzakas commented Apr 23, 2024

@fasttime just a reminder: if you approve a PR and don't merge it, please explain why you didn't merge it.

nzakas merged commit c621ab9 into main

37 checks passed

nzakas deleted the fix-next-version-date branch

April 23, 2024 17:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment