Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade node v20 & upgrade deps #208

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

build: upgrade node v20 & upgrade deps #208

wants to merge 9 commits into from

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 2, 2024 •
edited

upgrade deps:

fixes #205

@aladdin-add
Copy link
Member Author

it shows many warnings like this, but not a blocker to merge:

  console.warn
    Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.xxx()". Use "issue_number" instead

@aladdin-add aladdin-add marked this pull request as ready for review April 2, 2024 08:34
nzakas
nzakas approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

Would like another review before merging.

@mdjermanovic mdjermanovic added accepted dependencies Pull requests that update a dependency file labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic Awaiting requested review from mdjermanovic

Assignees
No one assigned
Labels
accepted build dependencies Pull requests that update a dependency file
Projects
Triage
Status: Second Review Needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot needs updating to be deployed
3 participants
@aladdin-add @nzakas @mdjermanovic