Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add ci to the project #70

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: Add ci to the project #70

wants to merge 3 commits into from

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Set up CI Workflow for Linting and Formatting.

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

@amareshsm amareshsm marked this pull request as ready for review October 19, 2024 18:44
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 7da0307
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/6713fe26a85daf0008e245ab
😎 Deploy Preview https://deploy-preview-70--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this triggered some linting errors. Check the "Files changed" tab to see them.

@amareshsm
Copy link
Member Author

It looks like this triggered some linting errors. Check the "Files changed" tab to see them.
I checked, and there were two warnings

  1. React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead

    const debouncedOnChange = useCallback(
    debounce((value: string) => {
    onChange?.(value);
    }, 400),
    [onChange],

    In the editor.tsx file, the onChange function we pass to useCallback receives a value as a prop to the component, which makes it unknown. Therefore, we can't use it as an inline function, so let's disregard this warning.

  2. React Hook useEffect has a missing dependency: 'fetchCodePath'. Either include it or remove the dependency array

    useEffect(() => {
    fetchCodePath();
    }, []);

    In the useEffect code block, we can't include fetchCodePath in the dependency array because we only want to call it during the initial render, not every time its dependencies change. Therefore, this change is unnecessary.

Therefore let's ignore both warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants