This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Add hexagonal topology to pso #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,6 +177,7 @@ void pso::evolve(population &pop) const | |||
| switch( m_neighb_type ){ | |||
| case 1: initialize_topology__gbest( pop, best_neighb, best_fit, neighb ); break; | |||
| case 3: initialize_topology__von( neighb ); break; | |||
| case 5: initialize_topology__hexagonal(neighb);break; | |||
There was a problem hiding this comment.
Why not the index order (1,3,4,5) ?
Two spaces after colon
|
I can't judge just by the code whether it's implemented correctly (do you have a reference implementation?). This needs some tests (ideally both C++ and Python) to verify that it works as reported in the literature. Do you have any data on it ? Update Python docstring: |
| void pso::initialize_topology__hexagonal( std::vector< std::vector<int> > &neighb ) const | ||
| { | ||
| int swarm_size = neighb.size(); | ||
| int cols, rows; // lattice structure |
There was a problem hiding this comment.
In this case there's no reason to align variable names in the column with multiple spaces, use a single space.
In this method you're using 8 spaces for indentation. We try to stick with tabs for C++ and 4 spaces for Python code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a hexagonal topology to pso. (I've fixed things that were wrong or missing in the previous PR)