Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Ensure that denormalize input is valid. #127

Closed
wants to merge 1 commit into from
Closed

Ensure that denormalize input is valid. #127

wants to merge 1 commit into from

Conversation

neduard
Copy link

@neduard neduard commented Mar 13, 2015

PR as per #120 (comment)

However, comparing against bound (-1.0 or 1.0) directly might cause problems when x[i] is close to it.
For example, x[i] might be 1.00000000000000001. In that case something like if (x[i] < (-1.0 - EPS) || x[i] > (1.0 + EPS)) might be recommended.

How/where should EPS be defined though?

@darioizzo
Copy link
Member

I am hesitant to merge this. I agree with the check, but one should then have a private method denormalize without the check (and called by the obj fun and contraint) and a public method performing the check and then calling the private method. This last would be exposed/offered to the user. Could you implement this?

@krzysztof
Copy link

Also, I don't think EPS is necessary here. If you want to make sure that the solution is within box [-1, 1]^n the (x[i] <= -1.0) || (x[i] >= 1.0) is the correct condition.

@krzysztof
Copy link

I am closing this for now, feel free to submit new PR or reopen if you're still interested in committing to this! :)

@krzysztof krzysztof closed this Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants