This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Sampling without replacement in jDE #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* Endless loop for NP < 8 !!! */ | ||
| r7 = p_idx(); | ||
| } while ((r7==i) || (r7==r1) || (r7==r2) || (r7==r3) || (r7==r4) || (r7==r5) || (r7==r6)); | ||
| if (NP < 21) { |
There was a problem hiding this comment.
Currently we include everything in the evolve() method. Would it be a good idea to separate the sampling algorithm (both for small and large NP) into a separate function?
|
@neduard Putting it into an external function is not necessary as it's so far the only place we use sampling wo replacement. Otherwise it would go in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from #95 (comment)
When taking population samples in jDE, if the population size (
NP) is small enough, we apply a sampling without replacement algorithm, otherwise we revert to previous behaviour.Testing was done by
make testsand a custom test bench:https://github.com/neduard/pagmo/blob/development/my_tutorials/myjdedev.cpp
This patch addresses issue #95