Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bold text style spilling after help info on Mac terminal #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JotaRandom
Copy link
Collaborator

Fixes #241

Signed-off-by: Pablo Lezaeta Reyes [email protected]
Signed-off-by: Ng Yik Phang

@JotaRandom
Copy link
Collaborator Author

I you still want add a comment to the lines or fix CONTRIBUTORS your name or update the CHANGELOG or something, fell free to do it.

If nothing is done in like a few days I will merge it anyway.

@maandree
Copy link
Collaborator

Changing [21m to [22m is not a good solution, change it to [0m or [m instead.

@JotaRandom
Copy link
Collaborator Author

Was mentioned in #241 that even node.js use 21, so is there any reason to preffer [0m or [m instead of [22m ?

alsp I will pag @ngyikp to comment on the issue and @erkin since he still the owner of the repo and maybe have even a 3th idea.

@maandree
Copy link
Collaborator

maandree commented Jun 17, 2017

22m should work. but the probability is less than for 0m.

@JotaRandom
Copy link
Collaborator Author

JotaRandom commented Jun 18, 2017

What is left to test is term.app (macOS) and I dont have a Mac to test so I will wait (anyways) for @ngyikp or another macOS user for they opinion on that alternative to use 0m.

@JotaRandom
Copy link
Collaborator Author

optionally we can just use one followed by the other.

also aparently some change now make the underscore be persistant on help so a clearing at the end of every --help invocation is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ponysay leaves terminal bold after running help command
3 participants