Impl From for Message for [u8;N] and u8
#352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
Nov 10, 2022
| @@ -229,6 +229,12 @@ impl<const N: usize> From<[u8; N]> for Message { | |||
| } | |||
| } | |||
|
|
|||
| impl From<u8> for Message { | |||
There was a problem hiding this comment.
Is this impl really useful? Conceptually it doesn't make a lot of sense...
There was a problem hiding this comment.
The usecase I personally found it sending a status response, i.e. a boolean, back to the other client. In which case it currently looks roughly like:
[struct.success as u8].as_slice()Which would then be:
struct.success as u8Initially I wanted to implement the From<T> for Message for anything that's either Into<u8> or AsRef<[u8]>, but that currently does not work without removing the impls for Box and Vec.
There was a problem hiding this comment.
With your other impl it's just [struct.success as u8] which seems good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.