Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new GC rules for release with version #6469

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

haiqingchq
Copy link
Contributor

What this PR does / why we need it:

Added a GC rule for releases with version on top of the original GC rule

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English add new GC rules for release with version
🇨🇳 中文 为带版本的制品添加新的 GC 规则

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 46.05263% with 41 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (12c9840) to head (da14758).

Files with missing lines Patch % Lines
...ternal/apps/dop/dicehub/release/release.service.go 41.81% 27 Missing and 5 partials ⚠️
internal/apps/dop/dicehub/release/db/release.go 57.14% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6469      +/-   ##
==========================================
+ Coverage   15.11%   15.12%   +0.01%     
==========================================
  Files        3675     3675              
  Lines      376996   377073      +77     
==========================================
+ Hits        56987    57040      +53     
- Misses     314559   314577      +18     
- Partials     5450     5456       +6     
Flag Coverage Δ
by-github-actions 15.12% <46.05%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/apps/dop/dicehub/release/db/release.go 10.95% <57.14%> (+7.24%) ⬆️
...ternal/apps/dop/dicehub/release/release.service.go 5.49% <41.81%> (+2.22%) ⬆️

... and 8 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants