Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dockerfiles of node.20.13 with pnpm 9 installed #41

Merged
merged 2 commits into from
May 29, 2024

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented May 29, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

Checklist

  • I made sure to check the compatibility of the erda version statemented in the action's spec.yml.
  • My change is adequately tested.

Copy link
Member

@chengjoey chengjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks

# Linux e2a008c89a1c 6.4.16-linuxkit #1 SMP PREEMPT_DYNAMIC Thu Nov 16 UTC 2023 x86_64 GNU/Linux
# Build cmd: docker build . -t terminus/debian-node-20.13 -f Dockerfile.debian.npm.10.5 --no-cache
# Other tags: terminus/debian-node:20.13-lts,terminus/debian-node:20.13
FROM --platform=$TARGETPLATFORM node:20.13.1-bookworm-slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--platform=$TARGETPLATFORM it's unnecessery

@sfwn
Copy link
Member

sfwn commented May 29, 2024

/approve

@erda-bot erda-bot added the approved Approve merging these changes label May 29, 2024
@erda-bot erda-bot merged commit 028a88b into erda-project:master May 29, 2024
2 checks passed
@hustcer hustcer deleted the feature/node20-pnpm9 branch May 29, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approve merging these changes
Development

Successfully merging this pull request may close these issues.

4 participants