Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/type hinting #96

Merged
merged 12 commits into from
Nov 29, 2023
Merged

Feat/type hinting #96

merged 12 commits into from
Nov 29, 2023

Conversation

smolvik1
Copy link
Collaborator

Describe your changes

  • Added type hinting
  • Refactored materials function in erosion.py
  • Removed geometry factor warnings above 4

Issues closed by this PR

Closes #93
Closes #72
Closes #91

Checklist before requesting a review

  • I have runned pytest locally with 100% success
  • If it is a core feature, I have added thorough tests.
  • I have bumped version number in pysand/version.py
  • I have updated changelog.md

@smolvik1 smolvik1 temporarily deployed to test_release October 25, 2023 19:59 — with GitHub Actions Inactive
@smolvik1 smolvik1 requested a review from sidsels October 25, 2023 20:00
@smolvik1 smolvik1 added the documentation Improvements or additions to documentation label Oct 25, 2023
@smolvik1 smolvik1 requested review from sogunneroed and FelixAntonio and removed request for sidsels October 30, 2023 14:20
@sogunneroed
Copy link
Collaborator

@smolvik1 looks good for me. @FelixAntonio when you have taken a look and if it looks okay we can merge it to master :) let me know if you want me to do it :) see that merging can be performed automacially with 1 approving review

FelixAntonio
FelixAntonio approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@FelixAntonio FelixAntonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Stian, thanks So and Stian for the explanation.

@FelixAntonio FelixAntonio merged commit eb1cf22 into master Nov 29, 2023
5 checks passed
@FelixAntonio FelixAntonio deleted the feat/type-hinting branch November 29, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogunneroed sogunneroed sogunneroed left review comments

@FelixAntonio FelixAntonio FelixAntonio approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement type hinting Change Hydro Transport description Remove geometry factor warning
3 participants
@smolvik1 @sogunneroed @FelixAntonio