Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show line number when cannot process a transaction #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

show line number when cannot process a transaction #102

wants to merge 1 commit into from

Conversation

splix
Copy link

@splix splix commented Sep 16, 2023

fix #101

eprbell
eprbell approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@eprbell eprbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: thanks for submitting the PR!

eprbell
eprbell requested changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@eprbell eprbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke too soon: there are a few unit test failures. Also the documentation failure is due to a dead link: I disabled the check for it, so if you rebase the code it should go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eprbell eprbell eprbell requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter 'crypto_fee' has zero value
2 participants
@splix @eprbell