-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stories rework: VaValue #3900
Stories rework: VaValue #3900
Conversation
I am very sorry that I forget to remove reluctant import, the pr is ready now. |
Hey. Thanks! We probably don't need last 2 stories (leave only Defaul), as VaValue component doesn't introduce any DOM. For first story it would be nice to have interaction test (you can check bactop for examples). |
I should've been moved two last stories to docs demo (or I actually did it). Since we moved to stories from demos, I think we can remove two last stories. We can add story of usage VaValue with reactive object, not just boolean. <VaValue :defaultValue="{ name: '', age: 0 }" #default="v">
<VaInput v-model="v.name" label="name" />
<VaInput v-model="v.age" label="name" />
</VaValue> I'm not sure if reactive object will work, but we need a story about it. |
Story rework of VaValue.
Part of #3676.
Types of changes