Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories rework: VaValue #3900

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Conversation

xiongmao86
Copy link
Contributor

Story rework of VaValue.
Part of #3676.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem requested a review from asvae September 25, 2023 08:27
@xiongmao86
Copy link
Contributor Author

I am very sorry that I forget to remove reluctant import, the pr is ready now.

@m0ksem m0ksem requested review from m0ksem and removed request for m0ksem September 27, 2023 09:57
@m0ksem m0ksem changed the title Fix/VaValue rework Stories rework: VaValue Sep 30, 2023
@asvae
Copy link
Member

asvae commented Oct 3, 2023

Hey. Thanks!

We probably don't need last 2 stories (leave only Defaul), as VaValue component doesn't introduce any DOM.
@m0ksem what do you think?

For first story it would be nice to have interaction test (you can check bactop for examples).

@m0ksem
Copy link
Collaborator

m0ksem commented Oct 3, 2023

Hey. Thanks!

We probably don't need last 2 stories (leave only Defaul), as VaValue component doesn't introduce any DOM. @m0ksem what do you think?

For first story it would be nice to have interaction test (you can check bactop for examples).

I should've been moved two last stories to docs demo (or I actually did it). Since we moved to stories from demos, I think we can remove two last stories.

We can add story of usage VaValue with reactive object, not just boolean.

<VaValue :defaultValue="{ name: '', age: 0 }" #default="v">
	<VaInput v-model="v.name" label="name" />
	<VaInput v-model="v.age" label="name" />
</VaValue>

I'm not sure if reactive object will work, but we need a story about it.

@xiongmao86
Copy link
Contributor Author

Thanks, @asvae, @m0ksem. I don't know how to check whether the reactive object case work. Is this commit ok?

@asvae asvae merged commit bf28e83 into epicmaxco:develop Oct 12, 2023
1 check passed
@asvae asvae mentioned this pull request Oct 12, 2023
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants