Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anchor-overscrolls): update css to fix anchor overscroll in main content #3889

Merged
merged 10 commits into from
Oct 31, 2023
Merged

fix(anchor-overscrolls): update css to fix anchor overscroll in main content #3889

merged 10 commits into from
Oct 31, 2023

Conversation

ItsKDaniel
Copy link
Contributor

@ItsKDaniel ItsKDaniel commented Sep 19, 2023 •
edited
Loading

Description

closes #3878

This PR sets overflow css to the main layout content area and updates scrollIntoView usage to enable anchor overscroll in main content.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Daniel added 4 commits September 19, 2023 19:06
fix: set content overflows to enable scrollbar for main content inste…
9f5a9da 
…ad of whole page
refactor: remove commented code
b79e24f
fix: use scrollIntoView instead of scrollTop attribute
7ca61e5
hack: use scroll behaviour auto instead of smooth
4c3431e 
for some reason, the scroll into view on click happens in UI after at least 2 clicks, if the behaviour is set to smooth.
may be set a timeout of 100 ms and wait for the browser to render the contents before scroll? 🤔
@ItsKDaniel ItsKDaniel mentioned this pull request Sep 19, 2023
Closed
asvae
asvae requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for you effort!

There is a critical regression in this PR so far.

packages/ui/src/components/va-layout/VaLayout.vue Outdated Show resolved Hide resolved
@m0ksem m0ksem merged commit 795f465 into epicmaxco:develop Oct 31, 2023
1 check passed
@ItsKDaniel ItsKDaniel deleted the fix#3878/anchor-overscrolls branch November 1, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae asvae requested changes

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchor overscrolls position
3 participants
@ItsKDaniel @asvae @m0ksem