-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story rework: VaVirtualScroller #3860
Story rework: VaVirtualScroller #3860
Conversation
Hi, I have most props test by step in storybook. But there are two issue I don't know how to handle:
Is there anything I have missed to do? |
Is it normal for UI Tests to fail? I haven't see anything related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, great work!
There is a bit or redundancy in old demos and this PR, apart from that - things are perfect.
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
Generally no (tests pass on develop). But you can ignore that for this PR 😁 as they have nothing to do with your changes (likely tests are broken because you branched off a while ago). |
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-virtual-scroller/VaVirtualScroller.stories.ts
Outdated
Show resolved
Hide resolved
Thanks, @asvae, How about the code now, anything I have missed? |
I did a couple of small changes, but overall it's perfect 🤗. |
Thank you very much, @asvae. |
Transform VaVirtualScroller to storybook.
Part of #3676.
Types of changes