Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace inline styles with tailwind classes in docs examples #3447

Merged
merged 5 commits into from
Jun 21, 2023
Merged

docs: replace inline styles with tailwind classes in docs examples #3447

merged 5 commits into from
Jun 21, 2023

Conversation

xiongmao86
Copy link
Contributor

@xiongmao86 xiongmao86 commented May 27, 2023 •
edited
Loading

Handles docs sections other than ui-element. Partly solve #3321.

Description

Replace inline styles with tailwind classes in examples

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@xiongmao86 xiongmao86 closed this May 30, 2023
@m0ksem m0ksem reopened this May 31, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented May 31, 2023

Let's have it. #3353 is missing styles for services and ag-grid, etc. (e.g. it has only fixed for ui-elements section).

@xiongmao86
Copy link
Contributor Author

Thanks very much, @m0ksem, I'll try to accommodate my branch.

@xiongmao86
Copy link
Contributor Author

All inline style of the document site is changed to tailwind class except ui-element. It's ready for review. Thanks.

@m0ksem m0ksem added the docs packages/docs label Jun 19, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Jun 19, 2023

Looks perfect as always.

@xiongmao86
Copy link
Contributor Author

Thanks very much, @m0ksem.

@m0ksem m0ksem changed the title Replace inline styles with tailwind classes in docs examples docs: replace inline styles with tailwind classes in docs examples Jun 21, 2023
@m0ksem m0ksem merged commit f517b4d into epicmaxco:develop Jun 21, 2023
@xiongmao86 xiongmao86 deleted the fix/replace-inline-styles branch June 22, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees
No one assigned
Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiongmao86 @m0ksem