Fix memory leak in SSR docs #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
changed the title
asvae
reviewed
May 10, 2023
packages/ag-grid-theme/package.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "@ag-grid-community/vue3": "^29.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "vuestic-ui": "^1.3.0" | |||
| "vuestic-ui": "1.6.4" | |||
asvae
reviewed
May 10, 2023
packages/deploy/package.json
Outdated
| "inquirer": "^9.0.0", | ||
| "typescript": "^4.3.2", | ||
| "chalk": "^5.0.1" | ||
| "typescript": "4.7.4", |
asvae
reviewed
May 10, 2023
asvae
reviewed
May 10, 2023
asvae
reviewed
May 10, 2023
asvae
reviewed
May 10, 2023
packages/nuxt/package.json
Outdated
| "pathe": "^0.3.5", | ||
| "vuestic-ui": "^1.4.10" | ||
| "vuestic-ui": "1.6.4" |
asvae
reviewed
May 10, 2023
| @@ -31,21 +31,21 @@ | |||
| "vue": "*" | |||
| }, | |||
| "devDependencies": { | |||
| "@vitejs/plugin-vue": "^1.3.0", | |||
There was a problem hiding this comment.
We can:
- use
*for non library projects (docs/sandbox) - use
^1.2.3for library projects (ui, ag-grid-pluign)
asvae
reviewed
May 10, 2023
asvae
requested changes
May 10, 2023
packages/ui/src/services/vue-plugin/create-vuestic/create-vuestic.ts
Outdated
Show resolved
Hide resolved
| @@ -1,4 +1,15 @@ | |||
| import type { ComponentOptionsBase, PropType, ExtractPropTypes } from 'vue' | |||
There was a problem hiding this comment.
We don't have props in docs for now.
tsconfig.json
Outdated
| @@ -1,22 +1,26 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "esnext", | |||
| "target": "es2018", | |||
tsconfig.json
Outdated
| "module": "esnext", | ||
| "strict": true, | ||
| "jsx": "preserve", | ||
| "importHelpers": true, | ||
| "moduleResolution": "node", | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
Maybe we can double check these changes?
Maybe we can delete this root tsconfig for good.
m0ksem
force-pushed
the
chore/docs-ssg-test
branch
from
9da301e
to
194e444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains massive changes related to dependencies to get SSG running.
Side effects:
Need QA.