Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3304] Redesign Vuestic landing #3340

Merged
merged 36 commits into from
Apr 20, 2023
Merged

[#3304] Redesign Vuestic landing #3340

merged 36 commits into from
Apr 20, 2023

Conversation

RVitaly1978
Copy link
Member

@RVitaly1978 RVitaly1978 commented Apr 17, 2023 •
edited
Loading

Description

close #3304
close #3347

  • update landing page
  • update overview page
  • fix landing.vue and default.vue nuxt layouts
screenshots

image

image

image

Screen.Recording.2023-04-17.at.19.47.39.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@RVitaly1978
fix(epicmaxco#3304): fix useSize composable
c0ed93b
@RVitaly1978
fix(epicmaxco#3304): update assets
65c0099
@RVitaly1978
fix(epicmaxco#3304): add svg images
d73b8a5
@RVitaly1978
fix(epicmaxco#3304): update vuestic-config
18339a5
@RVitaly1978
fix(epicmaxco#3304): update index
c3078b5
@RVitaly1978
fix(epicmaxco#3304): update HeaderBanner
6ce0431
@RVitaly1978
fix(epicmaxco#3304): update partner icons
8ac3a7d
@RVitaly1978
fix(epicmaxco#3304): add SocialsLinks component
2e1c7c8
@RVitaly1978
fix(epicmaxco#3304): update EpicmaxBanner component
7697271
@RVitaly1978
fix(epicmaxco#3304): update LanguageDropdown component
6b75b5a
@RVitaly1978
fix(epicmaxco#3304): update StarsButton component
50c53e2
@RVitaly1978
fix(epicmaxco#3304): update VuesticLogo component
aefb976
@RVitaly1978
fix(epicmaxco#3304): update Header
a19e594
@RVitaly1978
fix(epicmaxco#3304): update Preview
d54cef5
@RVitaly1978
fix(epicmaxco#3304): update Features
8fc9aa8
@RVitaly1978
fix(epicmaxco#3304): update Customize
a439a56
@RVitaly1978
fix(epicmaxco#3304): update Partners
dccce59
@RVitaly1978
fix(epicmaxco#3304): update SeamlessIntegration
91c6be7
@RVitaly1978
fix(epicmaxco#3304): update OpenSource
a443177
@RVitaly1978
fix(epicmaxco#3304): update Admin
32e5288
@RVitaly1978
fix(epicmaxco#3304): update Footer
14bf800
@RVitaly1978
fix(epicmaxco#3304): update locals
0b81d5c
@RVitaly1978
fix(epicmaxco#3304): update sitemap
352ecf0
@RVitaly1978
fix(epicmaxco#3304): remove facebook from socials
b89f6f6
@RVitaly1978
fix(epicmaxco#3304): remove outdated images
cd90f45
@RVitaly1978
fix(epicmaxco#3304): minor styles
313ce15
@RVitaly1978
fix(epicmaxco#3304): remove importing defineProps and defineEmits
a6dc935
@RVitaly1978
fix(epicmaxco#3304): update font-awesome to v6.4.0 and socials icons
5ff9af7
@RVitaly1978 RVitaly1978 self-assigned this Apr 17, 2023
@RVitaly1978 RVitaly1978 added the docs packages/docs label Apr 17, 2023
@RVitaly1978 RVitaly1978 requested a review from m0ksem April 18, 2023 07:11
@m0ksem
Copy link
Collaborator

m0ksem commented Apr 18, 2023

  • contrast issue in partners block:

image

  • IE icons seems inappropriate

image

While we have blue as accent color, it feels strange to have purple icons

Hand drawn icons feel inappropriate when all other design looks formal.

Text also not relevant. IMO "Support modern browsers" mean nothing, wondering if there are frameworks that support only old browsers lol. "No IE, sorry" also old and must be removed because it makes no sense (every vue3 framework do not support IE11 and it is not modern browser). I would change it to "responsive" only.

As a developer I will be interested in Developer Experience, SSR support, Keyboard Navigation and integration with other things like AgGrid, Tailwind, UnoCss, (maybe Laravel, rich text editors - we don't have this for now), etc. I change features list to:

Accessible & keyboard navigation support
- SSR friendly
- Focused on DX
- Integration with i18n, tailwind and more

  • "Customize everything" "Get started" button should redirect to some page related to customization. Perhaps we need some "Customization guide" page.

image

  • Overall, "Features" and "Customize Everything" look so much different from other sections.

Btw, first section looks perfect!

@m0ksem
Copy link
Collaborator

m0ksem commented Apr 18, 2023

@zvenigorodskaia, we must merge this PR in develop when it is completed. If you're going to review this, please, run project locally. Otherwise, the incomplete landing page will appear in production with tiny releases someday. For example, I've just fixed the form demos and if we merge this PR before, it would have ended up in production.

m0ksem
m0ksem approved these changes Apr 20, 2023
View reviewed changes
packages/docs/components/landing/Partners.vue Outdated
class="partners__logo"
>
<LandingIconsIconAgGrid />
</a>
</div>

<h3 class="partners__subtitle">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be h2, cuz it is a header of sponsors section (even if it smaller)

@m0ksem m0ksem merged commit 91c421d into epicmaxco:develop Apr 20, 2023
@RVitaly1978 RVitaly1978 deleted the 3304-vuestic-landing branch April 26, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvenigorodskaia zvenigorodskaia zvenigorodskaia approved these changes

@m0ksem m0ksem m0ksem approved these changes

Assignees

@RVitaly1978 RVitaly1978

Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar icons are missing Redesign Vuestic landing
3 participants
@RVitaly1978 @m0ksem @zvenigorodskaia