Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/file loading #3019

Merged
merged 9 commits into from
Feb 20, 2023
Merged

Fix/file loading #3019

merged 9 commits into from
Feb 20, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Feb 18, 2023

Fix minified file render in production

Added CSS Variables table to block.api

part of Page config compilation optimization

This breaks hot reload in dev mode (table doesn't refresh after file changed). It will be fixed later.

image

@m0ksem m0ksem added the docs packages/docs label Feb 18, 2023
@m0ksem m0ksem requested a review from aluarius February 18, 2023 09:36
@m0ksem m0ksem self-assigned this Feb 18, 2023
@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 18, 2023

For VaInputWrapper need to move variables in VaInput variables or create a way to show only css varialbes in block.api.

For example,

block.api('VaInputWrapper', { props: false, methods: false, events: false })

Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing css rules at the inner loading component docs.

image

packages/docs/modules/page-config/blocks/api/transform.ts Outdated Show resolved Hide resolved
packages/docs/page-config/ui-elements/image/index.ts Outdated Show resolved Hide resolved
packages/docs/page-config/ui-elements/input/index.ts Outdated Show resolved Hide resolved
packages/docs/page-config/ui-elements/modal/index.ts Outdated Show resolved Hide resolved
@rustem-nasyrov
Copy link
Collaborator

rustem-nasyrov commented Feb 19, 2023

Missing css rules at the inner loading component docs.

Still empty name column.
image

Also in the sidebar we have category duplication - it might be something wrong on my side. Could you please check it too?
image

@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 19, 2023

@rustem-nasyrov, double layout category fixed in 82cbd44 develop

@m0ksem
Copy link
Collaborator Author

m0ksem commented Feb 19, 2023

VaInnerLoading had wrong css variables name, so I changed them. Looks like breaking change, but I believe no one cares about it...

@m0ksem m0ksem merged commit db28129 into epicmaxco:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants