Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/2924 histoire support #2925

Closed
wants to merge 18 commits into from

Conversation

asvae
Copy link
Member

@asvae asvae commented Feb 6, 2023

closes #3293

Other:

  • Fix broken tests

image

@asvae asvae mentioned this pull request Feb 6, 2023
5 tasks
Copy link
Collaborator

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got infinite loading. None errors in the console.

@asvae
Copy link
Member Author

asvae commented Feb 7, 2023

Got infinite loading. None errors in the console.

@rustem-nasyrov can you explain what you have been doing to get an error? Just tried all docs/demos/histoire serve and everything was working fine for me.

@rustem-nasyrov
Copy link
Collaborator

@asvae

  1. Checkout to the your branch.
  2. yarn
  3. yarn run story:dev (with phpstorm runner)
  4. Open localhost:6006
  5. Infinite loading

image

And two pending requests:

image

@rustem-nasyrov rustem-nasyrov self-assigned this Feb 15, 2023
@rustem-nasyrov rustem-nasyrov marked this pull request as draft February 18, 2023 17:58
@rustem-nasyrov rustem-nasyrov added the blocked Blocked by another issue label Mar 10, 2023
@rustem-nasyrov
Copy link
Collaborator

rustem-nasyrov commented Mar 10, 2023

Blocked by old vite version.

@rustem-nasyrov rustem-nasyrov marked this pull request as ready for review March 31, 2023 16:43
@asvae asvae removed the blocked Blocked by another issue label Apr 1, 2023
@asvae asvae mentioned this pull request Apr 2, 2023
2 tasks
@rustem-nasyrov rustem-nasyrov marked this pull request as draft April 3, 2023 15:20
m0ksem and others added 3 commits April 6, 2023 23:29
* feat(ui): expose aria labels as props

* docs(select): description for aria label props

* fix(counter): label translation
* fix(epicmaxco#3036): update button and icons styles

* fix(epicmaxco#3036): tweak docs example

* fix(epicmaxco#3036): demo examples
…maxco#3274)

* fix(epicmaxco#3241): tweak expandableRow doc example

* fix(epicmaxco#3241): striped and hoverable styles

* fix(epicmaxco#3241): hoverable color for VaTable
RVitaly1978 and others added 8 commits April 6, 2023 23:30
…picmaxco#3271)

* fix(epicmaxco#3258): fix dropdown behaviour on content click

* refact(epicmaxco#3258): minor

* fix(epicmaxco#3258): time-input dropdown behavior on content click
* fix(epicmaxco#3078): add css variable

* fix(epicmaxco#3078): fix date-picker-cell colors
* fix(epicmaxco#3161): VaInputWrapper background and border

* fix(epicmaxco#3161): VaCounter buttons and styles

* fix(epicmaxco#3161): fix and add demo example with steps

* fix(epicmaxco#3161): fix docs slots and add example with steps

* fix(epicmaxco#3161): minor fix docs examples

* fix(epicmaxco#3161): remove outdated Hint example
* feat(va-value): init component

* docs(va-value): init component docs and added stateful default value

* chore: review fixes
@m0ksem
Copy link
Collaborator

m0ksem commented Aug 10, 2023

@asvae, can we decline this PR?

@m0ksem m0ksem closed this Aug 31, 2023
@asvae
Copy link
Member Author

asvae commented Aug 31, 2023

Sure. Nothing to salvage here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Deferred
Development

Successfully merging this pull request may close these issues.

Introduce Storybook
4 participants