Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation redirects for majority of pages #3363

Closed
1 of 4 tasks
asvae opened this issue Apr 21, 2023 · 6 comments
Closed
1 of 4 tasks

Documentation redirects for majority of pages #3363

asvae opened this issue Apr 21, 2023 · 6 comments
Assignees
Labels
BUG Something isn't working implementation Requires implementation

Comments

@asvae
Copy link
Member

asvae commented Apr 21, 2023

Vuestic-ui version: 1.6.4

Steps to reproduce

image

What is the expected behavior?

Should be 200.

What is the current behavior?

302

Other information

Page redirects to itself for some reason. This is not that visible for users, but really screws up crawlers. That's the reason search is broken in fact.

I tried to set detectBrowserLanguage: false in hope that was the reason for redirects, but alas it wasn't.

So, in context of this effort we need to

  • Fix the issue with redirects
  • Deploy to production and ensure Algolia functions properly. Maybe ping @m0ksem or @asvae to help with crawler, so that we can handle this issue efficiently.
  • Enable browser detection in nuxt
  • Test it again in Algolia and ensure everything works smootly
@asvae asvae added the BUG Something isn't working label Apr 21, 2023
@m0ksem m0ksem self-assigned this Apr 23, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Apr 23, 2023

Redirects likely fixed here in develop: #3364 Need QA, but I'm not able to reproduce it anymore.

@m0ksem m0ksem moved this from Todo to QA / Review in Vuestic Dashboard Apr 23, 2023
@asvae
Copy link
Member Author

asvae commented Apr 24, 2023

I'll take a look

merged to master

@asvae asvae added the team discussion Feedback wanted label Apr 24, 2023
@asvae
Copy link
Member Author

asvae commented Apr 24, 2023

302 issues seems to be fixed, but search still misses a lot of pages. (for example image)

@m0ksem
Copy link
Collaborator

m0ksem commented Apr 24, 2023

302 issues seems to be fixed, but search still misses a lot of pages. (for example image)

I've tried to crawl all pages today and get 83/120 chance for page to return network error. Not sure what it was, but the next crawl scheduled today.

@asvae
Copy link
Member Author

asvae commented Apr 24, 2023

@m0ksem you can force recrawl actually, no need to wait

@asvae asvae added implementation Requires implementation and removed team discussion Feedback wanted labels Apr 27, 2023
@asvae
Copy link
Member Author

asvae commented May 2, 2023

We fixed redirect parts, search issues moved to #3039

@asvae asvae closed this as completed May 2, 2023
@github-project-automation github-project-automation bot moved this from QA / Review to Done in Vuestic Dashboard May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working implementation Requires implementation
Projects
Archived in project
Development

No branches or pull requests

2 participants