Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algolia search doesn't work properly #3039

Closed
1 task
kushich opened this issue Feb 21, 2023 · 5 comments
Closed
1 task

Algolia search doesn't work properly #3039

kushich opened this issue Feb 21, 2023 · 5 comments
Assignees
Labels
BUG Something isn't working d3: medium No cheats. Monsters a bit faster. docs packages/docs research Requires research v2: nice to have This will make Vuestic feel better

Comments

@kushich
Copy link
Member

kushich commented Feb 21, 2023

We decided to use #3425 approach instead

In context of this task please only do enough to make search work.
There is no need to go through all examples and remove translations completely.


Algolia doesn't show some pages. I know that it takes some time to refresh its data after updates but we can't find even a scroll container component which we have for a long time.

Child issues:
Closes #2691
Closes #2645

  • When you search in vuestic.dev -> it opens the page, but only skeleton in shown; with open dev tools with cache disabled page is shown

Also see #3363

@kushich kushich added BUG Something isn't working docs packages/docs labels Feb 21, 2023
@asvae asvae added research Requires research v2: nice to have This will make Vuestic feel better d3: medium No cheats. Monsters a bit faster. labels Feb 22, 2023
@m0ksem m0ksem moved this to Todo in 2) 12.03 - 24.03 Mar 8, 2023
@rustem-nasyrov rustem-nasyrov self-assigned this Mar 9, 2023
@rustem-nasyrov rustem-nasyrov moved this from Todo to In Progress in 2) 12.03 - 24.03 Mar 9, 2023
@rustem-nasyrov
Copy link
Collaborator

Waiting for migration docs to the another hosting.

@rustem-nasyrov
Copy link
Collaborator

Pages are crawled, except few ones.

@asvae asvae moved this to Todo in Vuestic Dashboard Mar 28, 2023
@asvae asvae moved this from Todo to In Progress in Vuestic Dashboard Mar 28, 2023
@rustem-nasyrov rustem-nasyrov moved this from In Progress to Todo in Vuestic Dashboard Apr 7, 2023
@rustem-nasyrov rustem-nasyrov removed their assignment Apr 25, 2023
@misterpekert misterpekert moved this from Todo to In Progress in Vuestic Dashboard May 9, 2023
@misterpekert misterpekert self-assigned this May 9, 2023
@misterpekert
Copy link
Contributor

The configuration of Algolia to support multilanguage search is not easily implemented with indices built by the Algolia crawler. We should either consider providing a custom config for Algolia (sitemap with specific language for each page) and pass user language as a query to Algolia or have a separate index for each language. We can do so, as all localized pages are split by the lang prefix in the URL. After that, we would change the Algolia search index depending on the user's language in the doc settings. 2nd approach is more robust, but it'd be a problem to maintain (and support new languages).
Or we can drop translation support, stick to the English-only version, and reconsider this decision when necessary.

@misterpekert misterpekert removed their assignment May 12, 2023
@misterpekert misterpekert moved this from In Progress to Todo in Vuestic Dashboard May 12, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented May 12, 2023

The configuration of Algolia to support multilanguage search is not easily implemented with indices built by the Algolia crawler. We should either consider providing a custom config for Algolia (sitemap with specific language for each page) and pass user language as a query to Algolia or have a separate index for each language. We can do so, as all localized pages are split by the lang prefix in the URL. After that, we would change the Algolia search index depending on the user's language in the doc settings. 2nd approach is more robust, but it'd be a problem to maintain (and support new languages). Or we can drop translation support, stick to the English-only version, and reconsider this decision when necessary.

Dropping translation support is the solution. At least for now.

@asvae asvae moved this from Todo to In Progress in Vuestic Dashboard May 29, 2023
@asvae
Copy link
Member

asvae commented Jun 16, 2023

Fixed in 323a24a

It was hard to do in pull request (algolia only crawled ui.vuestic.dev), so hacked everything in master 🥷.

@asvae asvae closed this as completed Jun 16, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Vuestic Dashboard Jun 16, 2023
@zvenigorodskaia zvenigorodskaia moved this from Done to Approved in Vuestic Dashboard Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working d3: medium No cheats. Monsters a bit faster. docs packages/docs research Requires research v2: nice to have This will make Vuestic feel better
Projects
Archived in project
Status: In Progress
Development

No branches or pull requests

5 participants