Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inline styles with tailwind classes #3321

Closed
rustem-nasyrov opened this issue Apr 8, 2023 · 4 comments
Closed

Replace inline styles with tailwind classes #3321

rustem-nasyrov opened this issue Apr 8, 2023 · 4 comments
Assignees
Labels
d2: easy Recomended mode for new, but mature players docs packages/docs v2: nice to have This will make Vuestic feel better

Comments

@rustem-nasyrov
Copy link
Collaborator

We need to get rid of inline style in all docs examples if it's possible. :) Context:

There are several instances inside the docs/page-config/ui-elements/ like this:
image
Can be replaced with tailwind max-w-sm which is 24rem ( 384px ) or if we want to maintain the 400px, max-w-[400px].
There are other files within the folder that uses inline styles. I can create a new PR and transform them into tailwind classes instead of inline styles for code uniformity, if we're good to go with these changes?

Originally posted by @a-3140 in #3314 (comment)

@rustem-nasyrov rustem-nasyrov added docs packages/docs d2: easy Recomended mode for new, but mature players v2: nice to have This will make Vuestic feel better labels Apr 8, 2023
@xiongmao86
Copy link
Contributor

Hi, @rustem-nasyrov, I would like to take a stab of this, could you assign this issue to me?

@m0ksem
Copy link
Collaborator

m0ksem commented May 29, 2023

Hi, @rustem-nasyrov, I would like to take a stab of this, could you assign this issue to me?

Hi, @xiongmao86. I think we have already a draft pr for this issue! Sorry, haven't noticed earlier.

@xiongmao86
Copy link
Contributor

Ah, I'll close my pr.

@xiongmao86
Copy link
Contributor

This should probably close due to #3353.

@m0ksem m0ksem closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d2: easy Recomended mode for new, but mature players docs packages/docs v2: nice to have This will make Vuestic feel better
Projects
None yet
Development

No branches or pull requests

3 participants