Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add part of dashboard #1012

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Add part of dashboard #1012

merged 10 commits into from
Jan 23, 2024

Conversation

VasylHryha
Copy link
Contributor

@VasylHryha VasylHryha commented Jan 16, 2024

Description

closes #1011

Add only part of components, some of them not finished

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@VasylHryha VasylHryha requested review from asvae and m0ksem January 16, 2024 23:33
@VasylHryha VasylHryha self-assigned this Jan 16, 2024
@VasylHryha
Copy link
Contributor Author

feel free to rename components and refactor them.

const isLoading = ref(false)
const projects = ref<Project[]>([])

const { sorting = makeSortingRef(), pagination = makePaginationRef() } = options ?? {}

console.log(pagination.value.perPage)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed ?

@m0ksem
Copy link
Collaborator

m0ksem commented Jan 19, 2024

I made this PR work accordingly to figma design. I want to refactor it tomorrow.

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right to merge, but needs some more work to finish. I'll move all details to #1015

@asvae asvae merged commit 77383bd into epicmaxco:develop Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants