Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker]: Fixed date picker fail on scroll out. #2591

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Kuznietsov
Copy link
Collaborator

Summary

Problem: DatePicker body (Dropdown Body) was closed only on mouse-up event (click event). So, it was possible to scroll the dropdown target out of the screen, which led to page crush.

Solution: Added closing DropdownBody on mouse-down event, instead of click.

Bug reproduction

Screen.Recording.2024-10-30.at.14.32.40.mov

Solution behavior:

Screen.Recording.2024-10-30.at.14.35.05.mov

@Kuznietsov Kuznietsov self-assigned this Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Generated by: track-bundle-size
Generated at: Wed, 30 Oct 2024 12:51:56 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.10.0 (2024-10-15)
CI Status: ok

Module Baseline Size
(v5.10.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 760.53 764.18 +3.64
js:+3.88
css:-0.24
🆗 684.48 - 836.59
@epam/app 5578.86 5556.27 -22.6
js:+5.37
css:-27.96
🆗 5020.98 - 6136.75
@epam/draft-rte 53.77 53.78 +0.01
js:+0
css:+0.01
🆗 48.39 - 59.15
@epam/electric 4.57 4.59 +0.01
js:+0
css:+0.01
🆗 4.12 - 5.03
@epam/promo 57.15 57.18 +0.03
js:0
css:+0.03
🆗 51.44 - 62.87
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 93.74 93.8 +0.06
js:+0.01
css:+0.05
🆗 84.36 - 103.11
@epam/uui-components 263.21 264.11 +0.9
js:+0.93
css:-0.03
🆗 236.89 - 289.54
@epam/uui-core 337.45 337.81 +0.37
js:+0.37
css:0
🆗 303.7 - 371.19
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 207.12 207.12 0
js:+0
css:0
🆗 186.41 - 227.83
@epam/uui-editor 183.61 183.7 +0.09
js:+0.08
css:+0.01
🆗 165.25 - 201.97
@epam/uui-timeline 79.51 79.55 +0.04
js:+0.03
css:+0.01
🆗 71.56 - 87.46
@epam/uui 606.81 607.25 +0.44
js:+0.72
css:-0.29
🆗 546.13 - 667.49
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.10.2",
  "timestamp": "2024-10-30",
  "sizes": {
    "templateApp": {
      "css": 299796,
      "js": 482722
    },
    "@epam/app": {
      "css": 650334,
      "js": 5039284
    },
    "@epam/draft-rte": {
      "css": 9782,
      "js": 45295
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2409
    },
    "@epam/promo": {
      "css": 47661,
      "js": 10894
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53491,
      "js": 42554
    },
    "@epam/uui-components": {
      "css": 22501,
      "js": 247950
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 345921
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2444,
      "js": 209642
    },
    "@epam/uui-editor": {
      "css": 12743,
      "js": 175371
    },
    "@epam/uui-timeline": {
      "css": 2261,
      "js": 79199
    },
    "@epam/uui": {
      "css": 277481,
      "js": 344339
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 300 (+0) 🆗
Props 233 (+0) 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant