mobile: more flow control improvements #34303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
requested review from
RyanTheOptimist,
abeyad and
fredyw
as code owners
abeyad
previously approved these changes
May 22, 2024
| @@ -153,7 +153,7 @@ class ClientIntegrationTest | |||
| } | |||
|
|
|||
| void basicTest(); | |||
| void trickleTest(); | |||
| void trickleTest(bool final_chunk_empty); | |||
There was a problem hiding this comment.
I think this should also be final_chunk_has_data
Signed-off-by: Alyssa Wilk <[email protected]>
abeyad
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-ups on #34211 correctly handling fin-with-no-payload as well.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Fixes #34288