[network]Add ip address family info to error details upon socket connect failure

[RenjieTang]

Commit Message: Add ip address family info to error details upon socket connect failure
Additional Description: This helps reveal more info on why the socket connection fails immediately
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

[zuercher]

Probably want a space or some other delimiter at the start of "remote address family:" or it and the remote error will run together.

[zuercher]

Can you give an example where this clarifies an error?

[RenjieTang]

Can you give an example where this clarifies an error?

Recently we've seen a lot of socket errors of NO_ROUTE_TO_HOST emitted here. It took us quite some time to hypothesize that the socket is trying ipv6 connection when the network doesn't support it. With the addr family logged here, it'd be very clear that this is a ipv4/v6 connectivity issue.

[zuercher]

I recommend switching this to log the result of socket_->connectionInfoProvider().remoteAddress()->asString() like the other log messages in this file. Using socket_->connectionInfoProvider().remoteAddress()->ip() assumes all address instances are IP addresses, which is not true. That's why the tests are failing.

[RenjieTang]

I recommend switching this to log the result of socket_->connectionInfoProvider().remoteAddress()->asString() like the other log messages in this file. Using socket_->connectionInfoProvider().remoteAddress()->ip() assumes all address instances are IP addresses, which is not true. That's why the tests are failing.

Thanks for catching that. Done using string instead.

[adisuissa]

Approved by @zuercher, merging.