attribute: add upstream filter state #34284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I48b928db0e7b9b2d77dcafab0cbd897a7056b6ff Signed-off-by: Kuat Yessenov <[email protected]>
Change-Id: If19ba1e687b78a4a763380181f8dcf52ad02558c Signed-off-by: Kuat Yessenov <[email protected]>
nezdolik
reviewed
May 31, 2024
| @@ -162,7 +162,17 @@ Data exchanged between filters is available as the following attributes: | |||
| :widths: 1, 1, 4 | |||
|
|
|||
| metadata, :ref:`Metadata<envoy_v3_api_msg_config.core.v3.metadata>`, Dynamic request metadata | |||
| filter_state, "map<string, bytes>", Mapping from a filter state name to its serialized string value | |||
| filter_state, "map<string, Value>", Mapping from the filter state name to the object value | |||
There was a problem hiding this comment.
Curious, since this PR introduces new attribute upstream filter state only, why are we updating docs for filter_state attribute? Is it because the doc for this attribute is out of sync with the code?
nezdolik
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add upstream filter state accessor, for consistency with Wasm and log formatters.
Additional Description:
Risk Level: low
Testing: added
Docs Changes: yes
Release Notes: none