Issue 194 #195
Closed
Issue 194 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for exporting.
... for shapefile export.
| this.properties = new Properties(); | ||
| InputStream in = null; | ||
| try { | ||
| in = EEAPhenomenonLinker.class.getResourceAsStream(PROPERTIES); |
|
Oops, c&p mistake... I will correct this. We moved to #196, btw ;) The first (this) PR was aimed at the master branch... |
| private final String shapefileExportThresholdPropertyName = "shapefile.export.measurement.threshold"; | ||
| private Track track; | ||
| private Properties properties; | ||
| private static final String PROPERTIES = "/export.properties"; |
There was a problem hiding this comment.
I guess, depending on the ClassLoader implementation, this may always read the jar-packaged export.properties, thus prohibiting configuration at deployment time (WEB-INF/classes/export.properties).
I would recommend a fail-safe method: package an export.default.properties and only load it whenever Class.getResourceAsStream("/export.properties") returns null.
Merged
bpross-52n
added a commit
to bpross-52n/enviroCar-server
that referenced
this pull request
Jun 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #194. Measurement limit for shapefile export: 500 (configurable) Everything above that will result in a HTTP 500 error:
