Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass more info for evidence verification #76

Merged
merged 6 commits into from
Dec 25, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Dec 25, 2024

  • Pass shared_randomness to ProtocolError::verify_messages_constitute_error().
  • Pass guilty_party to verify_messages_constitute_error() (this is necessary since it is used as a part of the entry data for ZK proofs).
  • The above item causes a bit of a chain reaction, since now ProtocolError needs to be generic over Id, which means Protocol needs to be generic over Id, with the corresponding changes in all generic bounds throughout the crate.
  • Remove Combinator/CombinatorEntryPoint and replace it with a ChainedMarker trait, which works just as well.
  • The combined_echos argument to verify_messages_constitute_error() now has a mapping of id to echo instead of just a vector of echos.
  • verify_messages_constitute_error() now takes messages and mapping of messages by value.

@coveralls
Copy link

coveralls commented Dec 25, 2024

Pull Request Test Coverage Report for Build 12495825101

Details

  • 28 of 82 (34.15%) changed or added relevant lines in 7 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/protocol/errors.rs 0 2 0.0%
manul/src/protocol/round.rs 0 9 0.0%
manul/src/session/evidence.rs 23 43 53.49%
manul/src/combinators/chain.rs 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
manul/src/combinators/chain.rs 2 59.35%
manul/src/protocol/errors.rs 3 16.67%
manul/src/session/session.rs 5 80.35%
Totals Coverage Status
Change from base Build 11922968393: -0.3%
Covered Lines: 1788
Relevant Lines: 2589

💛 - Coveralls

@fjarri fjarri force-pushed the evidence-session-id branch from 578c4b3 to 4cffcb2 Compare December 25, 2024 19:06
@fjarri fjarri self-assigned this Dec 25, 2024
@fjarri fjarri merged commit 95450bf into entropyxyz:master Dec 25, 2024
8 checks passed
@fjarri fjarri deleted the evidence-session-id branch December 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants