[FEAT] Pinning and Tags #1541
Merged
[FEAT] Pinning and Tags #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnukvmd
reviewed
Apr 27, 2024
auth/lib/models/code.dart
Outdated
| } | ||
|
|
||
| @override | ||
| String toString() { |
There was a problem hiding this comment.
Not having a toString implementation will ensure we don't accidentally log sensitive data
ua741
reviewed
May 9, 2024
| for (final code in codes) { | ||
| data += "${code.rawData}\n"; | ||
| for (final code in allCodes.codes) { | ||
| data += "${code.rawDataWithoutDisplay}\n"; |
There was a problem hiding this comment.
Should we export with display? User might expect their tags to be available.
ua741
approved these changes
May 15, 2024
ua741
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pinning to auth
Tests