Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration with collaboration plugin #120

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

nikoPLP
Copy link

@nikoPLP nikoPLP commented Aug 6, 2024

Hello,
I noticed that plugin-split-editing is not compatible with @milkdown/plugin-collab and y-sync.
The reason why is that you filter out some transactions coming from editorView.dispatch, and that leaves the ones coming from y-sync out.
With the proposed fix, it now works well.

@enpitsuLin
Copy link
Owner

Thanks!

@enpitsuLin enpitsuLin merged commit 881e7f2 into enpitsuLin:master Aug 6, 2024
1 check failed
@nikoPLP
Copy link
Author

nikoPLP commented Aug 6, 2024

You are welcome! Thanks for your nice plugin and for accepting the PR quickly.
Do you know when you can make a minor version release and push it to npm ?
I have difficulties to build this plugin locally so I wasn't able to properly apply my own fix on my dev env and into the project that depends on it. So I would be looking for the next minor release in npm that contains the fix.

@enpitsuLin
Copy link
Owner

Yes, it's published to npm already

@nikoPLP
Copy link
Author

nikoPLP commented Aug 6, 2024

That's awesome! thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants