Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to have custom preview #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

desfero
Copy link

@desfero desfero commented Jun 23, 2023

This PR adds an ability to pass custom implementation of the preview component.

Simulator.Screen.Recording.-.iPhone.14.-.2023-06-23.at.16.34.11.mp4

TODO:

  • Cleanup the code
  • Document the changes
  • Understand the best way to have nice animation of reactions once it's hiding from the view.

@NoodleOfDeath
Copy link

OHHH I LIKE THIS!! I was trying to add some kind of 'willOpen' property but it needs be synchronously awaited before calculating the size of the component

@desfero
Copy link
Author

desfero commented Aug 7, 2023

Don't have time to fully finish this one in the short term future, if anyone wants to continue let me know.

@fukemy
Copy link

fukemy commented Aug 8, 2023

hi all, I just want to ask a question:

I saw the lib render {children} 2 times like this:

<GestureHandler>
        <Animated.View ref={containerRef} style={containerStyle}>
          {children} => HERE
        </Animated.View>
      </GestureHandler>

      <Portal key={key} name={key}>
        <Animated.View
          key={key}
          style={portalContainerStyle}
          animatedProps={animatedPortalProps}
        >
          <PortalOverlay />
          {children} => HERE
        </Animated.View>
      </Portal>

So does performance better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants