Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with Godot 4.4 prerelease #299

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Run tests with Godot 4.4 prerelease #299

merged 1 commit into from
Jan 7, 2025

Conversation

wjt
Copy link
Member

@wjt wjt commented Nov 4, 2024

This is potentially interesting because we have translation-related code
that behaves differently between 4.4 (which has some new API) and older
versions (which do not).

@wjt wjt force-pushed the push-lznrutvsqowt branch from 69d5538 to 01baea5 Compare November 4, 2024 10:31
@wjt
Copy link
Member Author

wjt commented Nov 4, 2024

The Godot 4.4 process segfaults when running tests – not too promising.

@wjt wjt force-pushed the push-lznrutvsqowt branch 3 times, most recently from 904f899 to de28fb1 Compare November 4, 2024 14:49
.github/workflows/checks.yaml Outdated Show resolved Hide resolved
@wjt wjt force-pushed the push-lznrutvsqowt branch 2 times, most recently from b734ac9 to 6964485 Compare December 18, 2024 11:37
@wjt wjt marked this pull request as ready for review December 18, 2024 11:56
@wjt wjt marked this pull request as draft December 18, 2024 11:59
@wjt wjt force-pushed the push-lznrutvsqowt branch 2 times, most recently from 84f9221 to c0bd30f Compare December 18, 2024 18:44
@manuq
Copy link
Contributor

manuq commented Dec 19, 2024

All checks have passed!

@wjt wjt force-pushed the push-lznrutvsqowt branch from c0bd30f to 4ab8a24 Compare December 19, 2024 09:26
@wjt wjt marked this pull request as ready for review December 19, 2024 09:26
This is potentially interesting because we have translation-related code
that behaves differently between 4.4 (which has some new API) and older
versions (which do not).
@wjt wjt force-pushed the push-lznrutvsqowt branch from 4ab8a24 to 9e473b3 Compare January 7, 2025 11:15
@wjt
Copy link
Member Author

wjt commented Jan 7, 2025

Updated this with -dev7 which was released late last year.

@wjt wjt merged commit 670a974 into main Jan 7, 2025
3 checks passed
@wjt wjt deleted the push-lznrutvsqowt branch January 7, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants