Run tests with Godot 4.4 prerelease #299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
force-pushed
the
push-lznrutvsqowt
branch
from
69d5538 to
01baea5
Compare
|
The Godot 4.4 process segfaults when running tests – not too promising. |
wjt
force-pushed
the
push-lznrutvsqowt
branch
2 times, most recently
from
b16923e to
904f899
Compare
This will make future diffs that add and remove engine versions more legible.
This is potentially interesting because we have translation-related code that behaves differently between 4.4 (which has some new API) and older versions (which do not).
wjt
force-pushed
the
push-lznrutvsqowt
branch
from
904f899 to
de28fb1
Compare
wjt
commented
Nov 4, 2024
| @@ -27,7 +27,10 @@ jobs: | |||
| name: Tests | |||
| strategy: | |||
| matrix: | |||
| godot-version: [4.2.2, 4.3.0] | |||
| godot-version: | |||
| - 4.2.2 | |||
There was a problem hiding this comment.
Do we still need 4.2 compatibility? I don't expect that anyone in the team still tests on 4.2. We could perhaps drop a few "workaround for Godot 4.2" bits that a quick search found in addons/block_code/ui/blocks/block/block.gd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potentially interesting because we have translation-related code
that behaves differently between 4.4 (which has some new API) and older
versions (which do not).