-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop hoist-non-react-statics
#3290
Conversation
🦋 Changeset detectedLatest commit: 2b9f15d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -98,5 +97,5 @@ export function withTheme< | |||
|
|||
WithTheme.displayName = `WithTheme(${componentName})` | |||
|
|||
return hoistNonReactStatics(WithTheme, Component) | |||
return WithTheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbf maybe we should just remove withTheme
altogether...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♀️ it takes like no code, is trivially tree shakable so I'd kinda err on the side of keeping it to just not break stuff but eh, I don't have strong feelings about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that’s also why i have decided to keep it in the end
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
No description provided.