Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop hoist-non-react-statics #3290

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Drop hoist-non-react-statics #3290

merged 2 commits into from
Dec 11, 2024

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist requested a review from emmatown December 10, 2024 09:33
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 2b9f15d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@emotion/react Major
@emotion/primitives-core Major
@emotion/styled Major
@emotion/native Major
@emotion/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -98,5 +97,5 @@ export function withTheme<

WithTheme.displayName = `WithTheme(${componentName})`

return hoistNonReactStatics(WithTheme, Component)
return WithTheme
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbf maybe we should just remove withTheme altogether...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️ it takes like no code, is trivially tree shakable so I'd kinda err on the side of keeping it to just not break stuff but eh, I don't have strong feelings about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that’s also why i have decided to keep it in the end

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Andarist Andarist merged commit 6158389 into next Dec 11, 2024
9 checks passed
@Andarist Andarist deleted the remove-hoist-statics branch December 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants