Fix JSX namespace @ts-ignores #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
emmatown
force-pushed
the
fix-jsx-namespace-ts-ignores
branch
from
8c81e27 to
51d662a
Compare
Andarist
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #3281 (comment) where I didn't explain the problem well, the comment I wrote in the code should clarify what the
@ts-ignores are solving here and how it wasn't working from switching to authoring in.tssince all the comments within declarations get removed.No changeset since it's just a fix for something that hasn't been released.
Also, while tests for this would probably be good, since we're probably gonna do a release to only support React 19 soon enough, I think this is fine.