-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetchpriority prop #2748
Add fetchpriority prop #2748
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4151544:
|
Hi, is there any interest in this? Otherwise I will close it. No hard feelings. |
This is an important SEO feature - could we please get this merged? |
I see that Styled Components uses |
@DustinBrett are you a maintainer here? otherwise: as last time there wasn't even a comment, i'm afraid it would be pointless to reopen it. |
Ah darn, well maybe one day it will get added. I might make a PR but who knows what will come of it. |
|
Thanks @DustinBrett ✌️ I would have never thought that a PR can take 2.5 years 😅 |
I would have never thought I'd maintain OSS projects instead of playing video games after days of full-time work and taking care of my family and kids... but hey, here we are 😉 This slipped through the cracks in the sea of notifications I get, sorry about that. |
I totally get that @Andarist. I'm grateful to anyone maintaining OSS! I was still surprised to see this change merged 2+ years after I closed my original PR 😉 |
What:
Adding the currently still non-standard
fetchpriority
prop.Why:
Priority hints are currently an unoffical W3C draft driven by Google (https://wicg.github.io/priority-hints/) but already supported in some Chromium-based browsers (https://caniuse.com/?search=fetchpriority). See also this article: https://web.dev/priority-hints/.
How:
Simply added the prop to
packages/is-prop-valid/src/props.js
, for now under the "Non-standard Properties".Checklist: