simplify types and add more tests

emotion-js · Jan 8, 2024 · 8869037 · 8869037
1 parent cc913db
commit 8869037
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/serialize/types/index.d.ts b/packages/serialize/types/index.d.ts
@@ -10,10 +10,8 @@ export type CSSProperties = CSS.PropertiesFallback<number | string>
 export type CSSPropertiesWithMultiValues<Props = unknown> = {
   [K in keyof CSSProperties]:
     | CSSProperties[K]
-    | ReadonlyArray<Extract<CSSProperties[K], string>>
-    | ((
-        props: Props
-      ) => CSSProperties[K] | ReadonlyArray<Extract<CSSProperties[K], string>>)
+    | ReadonlyArray<CSSProperties[K]>
+    | ((props: Props) => CSSProperties[K] | ReadonlyArray<CSSProperties[K]>)
 }
 
 export type CSSPseudos<Props = unknown> = {

diff --git a/packages/serialize/types/tests.ts b/packages/serialize/types/tests.ts
@@ -37,13 +37,16 @@ serializeStyles(
   {}
 )
 // $ExpectType SerializedStyles
-serializeStyles<{ vars: { background: string; foreground: string } }>([
+serializeStyles<{
+  vars: { background: string; foreground: string; step: number }
+}>([
   {
     display: () => ['-webkit-flex', 'flex'],
     backgroundColor: ({ vars }) => vars.background,
     color: ({ vars }) => vars.foreground,
     lineHeight: ({ vars }) => 1.2,
-    '--css-var': ({ vars }) => vars.foreground,
+    '--spacing': () => 1,
+    '--step': ({ vars }) => `calc(${vars.step} * var(--spacing))`,
     '&:hover': {
       backgroundColor: ({ vars }) => vars.foreground,
       color: ({ vars }) => vars.background
@@ -58,6 +61,8 @@ serializeStyles()
 // $ExpectError
 serializeStyles({})
 // $ExpectError
+serializeStyles([{ borderCollapse: () => 'unknown' }])
+// $ExpectError
 serializeStyles({}, {})
 
 let cssObject: CSSObject = {