Improve code readability #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument `-r` does not exists on tail command
emersonsoares
requested changes
Nov 27, 2019
There was a problem hiding this comment.
Hey, @rafaelfesi thanks for the readability improvements. The sorting problem is already solved by @gpad on #12. Can you, please update your PR with the latest changes on master and keep only the code improvements?
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| RELEASES_URI=https://raw.githubusercontent.com/dotnet/core/master/release-notes/releases-index.json | |||
| FILE="releases.json" | |||
| RELEASES_FILE="releases.json" | |||
| KEY="release-version" | |||
There was a problem hiding this comment.
What about to rename KEY to VERSION_KEY?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
asdf list-all dotnet-corewas not working due to inexistence of argument-rontailcommand.Also improves readability of the code.