Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to pnpm #1038

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Swap to pnpm #1038

merged 3 commits into from
Dec 20, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 20, 2024

With all the movement from @bertdeblock 's work I came here looking for a release-plan PR but we haven't set that up yet. I'm pretty sure that release-plan doesn't work with yarn classic so this PR is an attempt to swap over to pnpm.

It's a bit tricky because of the dual package-manager implementation in the smoke-test-app but we'll see if CI is happy 😂

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (d3b56f1) to head (0cea39b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1038   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          21       21           
  Lines         511      511           
=======================================
  Hits          488      488           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bertdeblock
Copy link
Member

We can also set the packageManager field in the package.json file like so.
Helps avoiding stuff like this.
Also allows us to remove with: version: 9 everywhere in the CI file,
so the package.json field is the single source of truth for the pnpm version.

@mansona
Copy link
Member Author

mansona commented Dec 20, 2024

@bertdeblock yea I tried that but alas we can't do that because of the strange npm/yarn smoke tests. Corepack keeps looking up the directories even though it's not a workspace and it complains that you are in a folder that defines a different thing in the package.json 😞

You can see the failure here: https://github.com/ember-cli/ember-try/actions/runs/12430792672/job/34706945429

Copy link
Member

@bertdeblock bertdeblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, too bad!

@bertdeblock bertdeblock changed the title swap to pnpm Swap to pnpm Dec 20, 2024
@mansona mansona merged commit 874252c into main Dec 20, 2024
35 checks passed
@mansona mansona deleted the pnpm branch December 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants