-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap to pnpm #1038
Swap to pnpm #1038
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 21 21
Lines 511 511
=======================================
Hits 488 488
Misses 23 23 ☔ View full report in Codecov by Sentry. |
@bertdeblock yea I tried that but alas we can't do that because of the strange npm/yarn smoke tests. Corepack keeps looking up the directories even though it's not a workspace and it complains that you are in a folder that defines a different thing in the package.json 😞 You can see the failure here: https://github.com/ember-cli/ember-try/actions/runs/12430792672/job/34706945429 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, too bad!
With all the movement from @bertdeblock 's work I came here looking for a release-plan PR but we haven't set that up yet. I'm pretty sure that release-plan doesn't work with yarn classic so this PR is an attempt to swap over to pnpm.
It's a bit tricky because of the dual package-manager implementation in the smoke-test-app but we'll see if CI is happy 😂