Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a completely separate adapter for yarn #1026

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

bertdeblock
Copy link
Member

Builds on #1025.

This separates the yarn-specific logic from the npm-specific logic.
This also introduces a BaseAdapter class to get rid of duplication and ensure more consistency among adapters.

@bertdeblock bertdeblock self-assigned this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (324be12) to head (c46951f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/dependency-manager-adapters/base.js 97.56% 2 Missing ⚠️
lib/utils/dependency-manager-adapter-factory.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   94.96%   95.44%   +0.48%     
==========================================
  Files          18       21       +3     
  Lines         556      505      -51     
==========================================
- Hits          528      482      -46     
+ Misses         28       23       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/dependency-manager-adapters/base.js Outdated Show resolved Hide resolved
lib/dependency-manager-adapters/pnpm.js Outdated Show resolved Hide resolved
@bertdeblock bertdeblock force-pushed the separate-yarn-adapter branch from b63eafc to 3a74a76 Compare December 12, 2024 19:43
.eslintrc.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@bertdeblock bertdeblock force-pushed the separate-yarn-adapter branch from 3a74a76 to c46951f Compare December 13, 2024 09:22
@bertdeblock bertdeblock merged commit e07ff04 into ember-cli:main Dec 13, 2024
37 checks passed
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants